[FINNA-2838] Add Finna specific OAI metadata format#3097
[FINNA-2838] Add Finna specific OAI metadata format#3097EreMaijala merged 11 commits intoNatLibFi:devfrom
Conversation
LuomaJuha
requested review from
EreMaijala
and removed request for
EreMaijala
EreMaijala
left a comment
EreMaijala
left a comment
There was a problem hiding this comment.
Tässä voisi olla hyötyä siitä, että yläjuoksulla tuo ensimmäinen blokki attachNonDeleted:stä irrotettaisiin omaksi metodiksi, jota attachNonDeleted kutsuu, niin ei tarvitsisi koko metodia yliajaa.
| $ref: '#/components/schemas/Url' | ||
| usageRights: | ||
| vufind.method: getUsageRights | ||
| description: Usage rights |
There was a problem hiding this comment.
Usage rights (see [usage_rights_str_mv at https://www.kiwi.fi/display/Finna/Kenttien+mappaukset+eri+formaateista+Finnan+indeksiin](https://github.com/NatLibFi/RecordManager-Finna/blob/dev/mappings/usage_rights.map.sample))
| type: string | ||
| usageRightsExtended: | ||
| vufind.method: getUsageRightsExt | ||
| description: Usage rights extended |
There was a problem hiding this comment.
Extended usage rights (see https://github.com/NatLibFi/RecordManager-Finna/blob/dev/mappings/usage_rights_ext.map.sample)
| // the supplied metadataPrefix is available. | ||
| // If RecordDriver returns nothing, skip this record. | ||
| if (empty($xml)) { | ||
| return true; |
LuomaJuha
added
in progress
upstream dependency
LuomaJuha
requested review from
EreMaijala
and removed request for
EreMaijala
| type: string | ||
| ctrlnum: | ||
| vufind.method: getCtrlNum | ||
| description: Ctrl num |
| type: string | ||
| majorGenres: | ||
| vufind.method: getMajorGenres | ||
| description: Major genres as array |
There was a problem hiding this comment.
Pelkkä Major genres (type: array kertoo tyypin)
| public function getMediaTypesAsStrings(): array | ||
| { | ||
| return array_map( | ||
| fn ($entry) => $entry instanceof \VuFind\I18n\TranslatableString ? $entry->__toString() : $entry, |
There was a problem hiding this comment.
Tässä pitäisi riittää (string)$entry kaikissa tapauksissa.
LuomaJuha
removed
the
upstream dependency
|
Hyvältä näyttää, mutta ajattelin, että voisi vielä selkeyttää noita kenttien ja metodien nimiä. |
Co-authored-by: Ere Maijala <ere.maijala@helsinki.fi>
Co-authored-by: Ere Maijala <ere.maijala@helsinki.fi>
Co-authored-by: Ere Maijala <ere.maijala@helsinki.fi>
Co-authored-by: Ere Maijala <ere.maijala@helsinki.fi>
2 participants
Adds couple fields to be exposed in the OAI response.
Could also be possible to open this in upstream with options to allow additional prefixes, but think it could be maybe unnecessary?
Requires: