Skip to content

Remove unused FlashAttention3 args#2898

Merged
santhnm2 merged 1 commit intoNVIDIA:mainfrom
santhnm2:fa3_args
Jan 12, 2026
Merged

Remove unused FlashAttention3 args#2898
santhnm2 merged 1 commit intoNVIDIA:mainfrom
santhnm2:fa3_args

Conversation

@santhnm2
Copy link
Contributor

What does this PR do ?

Removes unused FlashAttention3 args from the dynamic inference code.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2 santhnm2 requested review from a team as code owners January 10, 2026 08:06
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@santhnm2
Copy link
Contributor Author

/ok to test 9284ba1

@santhnm2 santhnm2 enabled auto-merge January 10, 2026 23:48
@ko3n1g ko3n1g added this to the Core 0.16 milestone Jan 10, 2026
@santhnm2 santhnm2 added this pull request to the merge queue Jan 11, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 11, 2026
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2026
@santhnm2 santhnm2 added this pull request to the merge queue Jan 12, 2026
Merged via the queue into NVIDIA:main with commit 4fc7935 Jan 12, 2026
72 of 77 checks passed
@santhnm2 santhnm2 deleted the fa3_args branch January 12, 2026 18:56
chtruong814 pushed a commit to chtruong814/Megatron-LM that referenced this pull request Jan 12, 2026
This reverts commit 4fc7935.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814 added a commit that referenced this pull request Jan 12, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Keshav Santhanam <ksanthanam@nvidia.com>
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Jan 14, 2026
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Jan 14, 2026
ko3n1g added a commit that referenced this pull request Jan 14, 2026
ArEsKay3 pushed a commit to tdene/Megatron-LM that referenced this pull request Jan 14, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: Keshav Santhanam <ksanthanam@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants