Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-04-14)#3319

Open
svcnvidia-nemo-ci wants to merge 3 commits intomainfrom
bump-ci-container-2026-04-14-main-dev
Open

chore(beep boop 🤖): Bump uv.lock (main, mcore-dev) (2026-04-14)#3319
svcnvidia-nemo-ci wants to merge 3 commits intomainfrom
bump-ci-container-2026-04-14-main-dev

Conversation

@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 14, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal development and build tooling references.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Copy Markdown
Contributor Author

/ok to test 4fa68c2

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 14, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: be5a93a5-971a-4213-a17f-89e0144fb039

📥 Commits

Reviewing files that changed from the base of the PR and between ad27e2c and 4fa68c2.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .dev.commit
  • 3rdparty/Megatron-LM

📝 Walkthrough

Walkthrough

This PR updates two commit references: the .dev.commit file and the 3rdparty/Megatron-LM submodule pointer, both pointing to the new commit 7ff046b1c8b976ff33761976796c4302ebd0a7bc.

Changes

Cohort / File(s) Summary
Commit Reference Updates
.dev.commit, 3rdparty/Megatron-LM
Updates stored commit identifiers and submodule pointer to 7ff046b1c8b976ff33761976796c4302ebd0a7bc, aligning development and third-party dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • maanug-nv
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping uv.lock but actually updates .dev.commit and a submodule reference, not uv.lock. The title is misleading and unrelated to the actual changes. Update the title to accurately describe the actual changes, such as 'chore: Update .dev.commit and Megatron-LM submodule reference' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed Pull request contains only minor maintenance changes: dependency lock file updates, version reference updates, and submodule pointer updates. These are automated chore updates requiring no test documentation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-14-main-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

…r and hybrid_context_parallel

state.py: wrap `EnergyMonitor` import in try/except (not yet in mcore dev),
add runtime guard before instantiation.

initialize.py: use inspect.signature to conditionally pass
`hybrid_context_parallel` kwarg to initialize_model_parallel (only in
mcore dev, not yet in main).

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Made-with: Cursor
@yaoyu-33
Copy link
Copy Markdown
Contributor

/ok to test ce40a56

…nting and state

mcore-dev does not have `async_strategy` param in `dist_checkpointing.save()`
or the `get_async_strategy` helper. Use `inspect.signature` to conditionally
pass `async_strategy`, and fall back to direct imports from mcore core modules
when `get_async_strategy` is unavailable.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33
Copy link
Copy Markdown
Contributor

/ok to test be0b8da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants