docs: add json output and search extensions#1588
Conversation
Documentation preview |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Greptile Summary
Important Files Changed
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
tgasser-nv
left a comment
There was a problem hiding this comment.
I built it locally with make docs-serve and the new search looks much better! I have a few questions:
- Could you address the Greptile feedback before merging?
- Are there any tests for the Python code that verify it works correctly?
Thanks!
Thank you! |
|
we can look into adding some tests, but for now there aren't any for these extensions. Ideally, this extension code would be living in the theme bundle itself... this is kind of a workaround haha. |
At a minimum, can we make sure the build pipeline is self-checking? So if for some reason the extensions broke the docs build we'd get an alert and could go back in and fix it? My concern is we'd end up breaking the docs due to the nice search code and not realise. Do you have any plans to build the extension into the theme longer-term? |
Hey @tgasser-nv, the real long-term plan is actually to migrate to Fern and stop using Sphinx. I built this extension before that decision was made, but FWIW both extensions are also designed defensively:
The publish command is already strict/self checking and fails even on warnings -- so even if one link is broken or page not added to a toctree, you'd get blocked. If you'd prefer to just close this and focus on migration, that might be better. I have staged PRs for exactly that for Data Designer and NeMo Curator you can take a look at. Heavy AI was the first to make the move. |
Hi @lbliii thanks for your reply. As long as we catch broken docs builds and don't push them to prod I'm happy to merge the extension. It's a much better experience for customers compared to the search page today and I'd rather get the improvements now rather than wait for a future migration. Thanks! |
tgasser-nv
left a comment
There was a problem hiding this comment.
Approved as we catch failing docs builds and don't push them to production. Thanks @lbliii !
|
Applied part of the greptile suggestions, and the rest we decided to ignore. Thank you @tgasser-nv for your review! |
Description
Add JSON output extension, and also apply metadata-fed search interface extension from DORI built by @lbliii
Related Issue(s)
Checklist