Skip to content

[CI] Fix formatting for clang-format-18 and silence warnings/errors on newer GCC#243

Merged
rhdong merged 1 commit intoNVIDIA-Merlin:masterfrom
rhdong:hrong/tk-feats-dev
Feb 18, 2026
Merged

[CI] Fix formatting for clang-format-18 and silence warnings/errors on newer GCC#243
rhdong merged 1 commit intoNVIDIA-Merlin:masterfrom
rhdong:hrong/tk-feats-dev

Conversation

@rhdong
Copy link
Copy Markdown
Member

@rhdong rhdong commented Feb 3, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

@rhdong rhdong force-pushed the hrong/tk-feats-dev branch from 3842577 to f7e5ea1 Compare February 4, 2026 00:03
@rhdong rhdong changed the title [CI] fix format under clang-format-18 [CI] Fix formatting for clang-format-18 and silence warnings/errors on newer GCC Feb 4, 2026
Copy link
Copy Markdown
Collaborator

@jiashuy jiashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Copy Markdown
Member Author

rhdong commented Feb 11, 2026

/blossom-ci

@rhdong rhdong force-pushed the hrong/tk-feats-dev branch from f7e5ea1 to 9906da2 Compare February 18, 2026 02:09
@rhdong
Copy link
Copy Markdown
Member Author

rhdong commented Feb 18, 2026

@jiashuy The CI tests are passing locally now. Thanks for the review!

                                                                                                                                                                
  PR #243 Test Results - ALL PASSED                                                                                                                             
  
  GPU: NVIDIA RTX A6000, 48GB | Branch: rhdong/HierarchicalKV @ hrong/tk-feats-dev                                                                              
                                                            
  ┌─────┬──────────────────────────────┬───────┬────────┬──────────┐
  │  #  │         Test Binary          │ Tests │ Result │ Duration │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 1   │ find_with_missed_keys_test   │ 3     │ PASSED │ 24.7s    │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 2   │ accum_or_assign_test         │ 14    │ PASSED │ 226.6s   │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 3   │ find_or_insert_ptr_test      │ 18    │ PASSED │ 765.4s   │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 4   │ find_or_insert_test          │ 19    │ PASSED │ ~800s    │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 5   │ find_or_insert_ptr_lock_test │ 13    │ PASSED │ ~500s    │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 6   │ insert_and_evict_test        │ 8     │ PASSED │ 794.3s   │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 7   │ save_and_load_test           │ 5     │ PASSED │ 11.3s    │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 8   │ merlin_hashtable_test        │ 21    │ PASSED │ 1052.4s  │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 9   │ group_lock_test              │ 3     │ PASSED │ 14.6s    │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 10  │ assign_values_test           │ 3     │ PASSED │ 126.0s   │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 11  │ assign_score_test            │ 8     │ PASSED │ 442.7s   │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 12  │ reserved_keys_test           │ 1     │ PASSED │ 0.1s     │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 13  │ dynamic_max_capacity_test    │ -     │ PASSED │ -        │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 14  │ export_batch_if_test         │ -     │ PASSED │ -        │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 15  │ lock_unlock_test             │ -     │ PASSED │ -        │
  ├─────┼──────────────────────────────┼───────┼────────┼──────────┤
  │ 16  │ merlin_memory_pool_test      │ -     │ PASSED │ -        │
  └─────┴──────────────────────────────┴───────┴────────┴──────────┘

@rhdong rhdong merged commit bbe2ee1 into NVIDIA-Merlin:master Feb 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants