Skip to content

🎨 Palette: Add dynamic context to list action accessibility labels#73

Open
NSEvent wants to merge 2 commits into
mainfrom
palette/dynamic-accessibility-labels-13832839771554257984
Open

🎨 Palette: Add dynamic context to list action accessibility labels#73
NSEvent wants to merge 2 commits into
mainfrom
palette/dynamic-accessibility-labels-13832839771554257984

Conversation

@NSEvent

@NSEvent NSEvent commented Jul 3, 2026

Copy link
Copy Markdown
Owner

💡 What: Updated the accessibilityLabel and help tooltips on the "Edit" and "Delete" icon buttons in MacroListView and ScriptListView to include the specific item's name dynamically.
🎯 Why: In a list with multiple macros or scripts, having repeated buttons all labeled just "Edit" or "Delete" causes ambiguity for screen readers and in tooltips. Adding the item name provides clear context about which item is being acted upon.
♿ Accessibility: Improves VoiceOver experience and visual hover clarity by disambiguating repeated action buttons.


PR created automatically by Jules for task 13832839771554257984 started by @NSEvent

Summary by CodeRabbit

  • Bug Fixes
    • Improved action button tooltips and accessibility labels so edit/delete controls clearly identify the specific macro or script they apply to.
    • Added clearer fallback text for unnamed scripts to keep labels understandable.
  • Accessibility
    • Screen-reader labels now include item-specific context, reducing ambiguity when multiple rows have the same action buttons.

💡 What: Updated the `accessibilityLabel` and `help` tooltips on the "Edit" and "Delete" icon buttons in `MacroListView` and `ScriptListView` to include the specific item's name dynamically.
🎯 Why: In a list with multiple macros or scripts, having repeated buttons all labeled just "Edit" or "Delete" causes ambiguity for screen readers and in tooltips. Adding the item name provides clear context about which item is being acted upon.
♿ Accessibility: Improves VoiceOver experience and visual hover clarity by disambiguating repeated action buttons.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@NSEvent, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 790c3209-b4d9-448c-a822-3c8ea10bc97a

📥 Commits

Reviewing files that changed from the base of the PR and between 446954a and 798eb67.

📒 Files selected for processing (2)
  • find_failed_tests.py
  • find_test_failures.py
📝 Walkthrough

Walkthrough

Updates macro and script list row action buttons so their tooltip (.help) and accessibility label text include the specific item's name instead of generic "Edit"/"Delete" text. Adds a corresponding guidance entry to .Jules/palette.md documenting this pattern.

Changes

Dynamic Action Labels

Layer / File(s) Summary
Macro row action labels
XboxControllerMapper/.../MacroListView.swift
SharedMacroRow and MacroRow edit/delete buttons now use macro.name in .help and .accessibilityLabel instead of generic strings.
Script row action labels
XboxControllerMapper/.../ScriptListView.swift
ScriptRow computes a displayName (falling back to "Untitled Script") and uses it in edit/delete .help and .accessibilityLabel strings.
Palette guidance documentation
.Jules/palette.md
Adds a dated section instructing icon-only action buttons to include dynamic per-item context in tooltips and accessibility labels.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding dynamic context to list action accessibility labels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/dynamic-accessibility-labels-13832839771554257984

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

💡 What: Updated the `accessibilityLabel` and `help` tooltips on the "Edit" and "Delete" icon buttons in `MacroListView` and `ScriptListView` to include the specific item's name dynamically.
🎯 Why: In a list with multiple macros or scripts, having repeated buttons all labeled just "Edit" or "Delete" causes ambiguity for screen readers and in tooltips. Adding the item name provides clear context about which item is being acted upon.
♿ Accessibility: Improves VoiceOver experience and visual hover clarity by disambiguating repeated action buttons.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant