🎨 Palette: Dynamic Context for Repeated List Actions by NSEvent · Pull Request #72 · NSEvent/xbox-controller-mapper

NSEvent · 2026-07-02T09:39:46Z

🎨 Palette: [Dynamic Context for Repeated List Actions]

💡 What: Added dynamic context to accessibility labels and tooltips for list actions like Edit, Delete, and Remove.
🎯 Why: When using generic actions in repeated list rows, screen reader users hear only the action without context (e.g., "Edit, button. Delete, button."). Adding the item name (e.g., "Edit MacroName") makes navigation unambiguous.
♿ Accessibility: Improved screen reader experience in MacroListView, ScriptListView, MacroEditorSheet, and ActionMappingEditor.

PR created automatically by Jules for task 10948893955258345891 started by @NSEvent

Summary by CodeRabbit

New Features
- Improved accessibility text for repeated edit/delete actions across macros, scripts, and webhook headers.
- Action buttons now include item-specific context, making screen reader navigation clearer and less ambiguous.
Bug Fixes
- Replaced generic labels like “Edit,” “Delete,” and “Remove header” with contextual names such as the macro name, script name, or header key.
- Added a fallback label for unnamed scripts to keep controls understandable.

- 💡 What: Added dynamic context to accessibility labels and tooltips for list actions like Edit, Delete, and Remove. - 🎯 Why: When using generic actions in repeated list rows, screen reader users hear only the action without context (e.g., "Edit, button. Delete, button."). Adding the item name (e.g., "Edit MacroName") makes navigation unambiguous. - ♿ Accessibility: Improved screen reader experience in MacroListView, ScriptListView, MacroEditorSheet, and ActionMappingEditor. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>

google-labs-jules · 2026-07-02T09:39:47Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-07-02T09:40:11Z

📝 Walkthrough

Walkthrough

This PR updates SwiftUI .help() and .accessibilityLabel() strings for repeated icon-only edit/delete/remove-header buttons across macro, script, and webhook header views, replacing generic text with per-item context (macro name, script name, header key). A documentation entry describing this pattern is added to the palette guide.

Changes

Dynamic accessibility labels

Layer / File(s)	Summary
Palette documentation rule `.Jules/palette.md`	Adds a rule stating repeated list row action labels should include dynamic per-item context.
Macro list and editor labels `XboxControllerMapper/.../Macros/MacroListView.swift`, `XboxControllerMapper/.../Macros/MacroEditorSheet.swift`	Edit/delete buttons in `SharedMacroRow` and `MacroRow` include the macro name; webhook header remove button in `MacroEditorSheet` includes the header key.
Action mapping editor header labels `XboxControllerMapper/.../MainWindow/ActionMappingEditor.swift`	Remove header button's help/accessibility text includes the specific header key.
Script list row labels `XboxControllerMapper/.../Scripts/ScriptListView.swift`	Adds a `displayName` derived from the script name for edit/delete button labels and simplifies button actions to call `onEdit`/`onDelete` directly.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

NSEvent/xbox-controller-mapper#24: Both PRs extend the same accessibility guidance in .Jules/palette.md for icon-only action buttons.
NSEvent/xbox-controller-mapper#42: This PR's dynamic-context labels build directly on the tooltip/accessibility modifiers added in that PR for the same buttons.
NSEvent/xbox-controller-mapper#53: Refines the same webhook header remove button labels in ActionMappingEditor.swift first added in that PR.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main accessibility change by adding dynamic context to repeated list actions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch palette-ux-dynamic-accessibility-labels-10948893955258345891

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

🧹 Nitpick comments (1)

XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroEditorSheet.swift (1)
642-653: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider deduplicating the webhook header row UI.

This webhook header row block (including the newly updated help/accessibility strings) is now duplicated nearly verbatim in ActionMappingEditor.swift (Lines 372-388). Extracting a shared WebhookHeaderRow view would keep both copies in sync going forward. Not introduced by this PR, so purely optional.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroEditorSheet.swift`
around lines 642 - 653, The webhook header row UI in MacroEditorSheet is
duplicated with the same pattern in ActionMappingEditor, so extract the shared
row into a reusable WebhookHeaderRow view and use it from both places; move the
HStack contents, the remove button, and the help/accessibility labels into that
shared component so both editors stay in sync.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroEditorSheet.swift`:
- Around line 642-653: The webhook header row UI in MacroEditorSheet is
duplicated with the same pattern in ActionMappingEditor, so extract the shared
row into a reusable WebhookHeaderRow view and use it from both places; move the
HStack contents, the remove button, and the help/accessibility labels into that
shared component so both editors stay in sync.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 13858024-af32-4ab2-9c3c-8ff979eee85e

📥 Commits

Reviewing files that changed from the base of the PR and between 95d4928 and ddba120.

📒 Files selected for processing (5)

.Jules/palette.md
XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroEditorSheet.swift
XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ActionMappingEditor.swift
XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift

coderabbitai Bot reviewed Jul 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🎨 Palette: Dynamic Context for Repeated List Actions#72

🎨 Palette: Dynamic Context for Repeated List Actions#72
NSEvent wants to merge 1 commit into
mainfrom
palette-ux-dynamic-accessibility-labels-10948893955258345891

NSEvent commented Jul 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

google-labs-jules Bot commented Jul 2, 2026

Uh oh!

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

NSEvent commented Jul 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

google-labs-jules Bot commented Jul 2, 2026

Uh oh!

coderabbitai Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

NSEvent commented Jul 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading