Skip to content

🎨 Palette: Add dynamic accessibility labels to list item action buttons#66

Open
NSEvent wants to merge 1 commit into
mainfrom
palette-dynamic-accessibility-labels-4690528951287490734
Open

🎨 Palette: Add dynamic accessibility labels to list item action buttons#66
NSEvent wants to merge 1 commit into
mainfrom
palette-dynamic-accessibility-labels-4690528951287490734

Conversation

@NSEvent

@NSEvent NSEvent commented Jun 26, 2026

Copy link
Copy Markdown
Owner

💡 What: Added dynamic item names to the accessibility labels and help tooltips for the "Edit" and "Delete" icon-only buttons in MacroListView and ScriptListView.
🎯 Why: In lists with repeating icon buttons, standard labels like "Edit" provide no context. Screen readers and users hovering over the button will now receive explicit context (e.g., "Edit My Script" instead of just "Edit"), making the interface much more accessible and intuitive.
📸 Before/After: Visuals are unchanged; tooltips and screen reader callouts are improved.
♿ Accessibility: Ensures that list action items are completely unambiguous for VoiceOver users and provides clear hover context.


PR created automatically by Jules for task 4690528951287490734 started by @NSEvent

Summary by CodeRabbit

  • Bug Fixes
    • Improved button labels and help text in macro and script lists so they now include the specific item name, making actions clearer.
    • Shared macro actions now reference the shared macro name instead of generic text.
    • Script actions now fall back to “Untitled Script” when a script name is missing.

Updated MacroListView and ScriptListView to use dynamic names in the .help() and .accessibilityLabel() modifiers for the Edit and Delete buttons. This provides better context for screen readers and tooltips instead of repeating generic actions.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cb14e3e-ae47-46cf-ab7b-b9cca5c6925e

📥 Commits

Reviewing files that changed from the base of the PR and between fbd7b08 and 2a14e4f.

📒 Files selected for processing (2)
  • XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift
  • XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift

📝 Walkthrough

Walkthrough

Macro and script row action buttons now expose per-item help text and accessibility labels for Edit and Delete. Shared macro rows use the macro name, and script rows use the script name with an Untitled Script fallback.

Changes

Row action accessibility labels

Layer / File(s) Summary
Name-specific edit and delete labels
XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift, XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift
Edit and Delete help text and accessibility labels now include each row’s macro or script name; shared macro edits use macro.name, and scripts fall back to Untitled Script when empty.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 I hopped through macros, and scripts did too,
with Edit and Delete that say exactly who.
“Untitled Script” gets a lantern glow,
so every button says where to go. 🥕
My whiskers twitch—clear labels make a merry show!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: dynamic accessibility labels for list item action buttons.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-dynamic-accessibility-labels-4690528951287490734

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant