🎨 Palette: Add dynamic accessibility labels to list item action buttons#66
🎨 Palette: Add dynamic accessibility labels to list item action buttons#66NSEvent wants to merge 1 commit into
Conversation
Updated MacroListView and ScriptListView to use dynamic names in the .help() and .accessibilityLabel() modifiers for the Edit and Delete buttons. This provides better context for screen readers and tooltips instead of repeating generic actions. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMacro and script row action buttons now expose per-item help text and accessibility labels for Edit and Delete. Shared macro rows use the macro name, and script rows use the script name with an ChangesRow action accessibility labels
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Added dynamic item names to the accessibility labels and help tooltips for the "Edit" and "Delete" icon-only buttons in
MacroListViewandScriptListView.🎯 Why: In lists with repeating icon buttons, standard labels like "Edit" provide no context. Screen readers and users hovering over the button will now receive explicit context (e.g., "Edit My Script" instead of just "Edit"), making the interface much more accessible and intuitive.
📸 Before/After: Visuals are unchanged; tooltips and screen reader callouts are improved.
♿ Accessibility: Ensures that list action items are completely unambiguous for VoiceOver users and provides clear hover context.
PR created automatically by Jules for task 4690528951287490734 started by @NSEvent
Summary by CodeRabbit