Skip to content

🎨 Palette: Add dynamic accessibility context to Community Profile checkbox#64

Open
NSEvent wants to merge 1 commit into
mainfrom
palette-a11y-community-profile-row-2321091371159725096
Open

🎨 Palette: Add dynamic accessibility context to Community Profile checkbox#64
NSEvent wants to merge 1 commit into
mainfrom
palette-a11y-community-profile-row-2321091371159725096

Conversation

@NSEvent

@NSEvent NSEvent commented Jun 24, 2026

Copy link
Copy Markdown
Owner
  • 💡 What: Added .help and .accessibilityLabel modifiers to the checkmark selection button in the Community Profiles list.
  • 🎯 Why: The icon-only button (circle / checkmark.circle.fill) lacked a tooltip for hover context and had no screen reader label, leaving VoiceOver users without any context on what the button toggles. Additionally, context uses the profileInfo.displayName to disambiguate identical-looking toggles in the list.
  • 📸 Before/After: No visual changes besides standard system tooltips.
  • Accessibility: VoiceOver now correctly reads "Select [Profile Name]" or "Deselect [Profile Name]" rather than just announcing "button".

PR created automatically by Jules for task 2321091371159725096 started by @NSEvent

Summary by CodeRabbit

  • Accessibility Improvements
    • Added clearer labels and help text for icon-only selection controls, making it easier to understand what each button does.
    • Selection checkboxes now announce whether they will select or deselect a profile, with the profile name included for clarity.

Adds `.help()` and `.accessibilityLabel()` modifiers with dynamic context (the profile's display name) to the icon-only selection button in the `CommunityProfileRow` list view. This improves UX for VoiceOver users and provides visual tooltips on hover.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 908be4d9-ea50-46fa-bf5d-acfb8b03fe1f

📥 Commits

Reviewing files that changed from the base of the PR and between 0eebc97 and 089192e.

📒 Files selected for processing (2)
  • .Jules/palette.md
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/CommunityProfilesSheet.swift

📝 Walkthrough

Walkthrough

The PR adds .help(...) and .accessibilityLabel(...) modifiers to the icon-only selection checkbox button in CommunityProfileRow, using profileInfo.displayName and the current selection state to generate dynamic text. A matching palette entry documents this accessibility pattern for icon-only list controls.

Changes

Community Profile Checkbox Accessibility

Layer / File(s) Summary
Checkbox accessibility modifiers and palette guidance
XboxControllerMapper/.../CommunityProfilesSheet.swift, .Jules/palette.md
Adds dynamic .help(...) and .accessibilityLabel(...) to the profile selection checkbox (select/deselect wording derived from profileInfo.displayName and current selection state), and records the icon-only control accessibility pattern in the palette.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐇 Hop, hop — a label appears!
The checkbox now speaks to all ears,
"Select" or "deselect" it cries,
With a name that helps blind eyes.
The palette records the deed,
Accessibility guaranteed! ✅

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main change: adding dynamic accessibility context to the Community Profile selection control.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-a11y-community-profile-row-2321091371159725096

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant