Skip to content

Batch of modules removal#1219

Merged
targos merged 5 commits intomasterfrom
rm-more-modules
Mar 12, 2026
Merged

Batch of modules removal#1219
targos merged 5 commits intomasterfrom
rm-more-modules

Conversation

@targos
Copy link
Collaborator

@targos targos commented Mar 12, 2026

No description provided.

@targos targos requested a review from stropitek March 12, 2026 15:10
@targos targos mentioned this pull request Mar 12, 2026
30 tasks
Copy link
Collaborator

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I just came across an onde module in an ELN view (request management view), so I would not say it's not used.

Will we do a major version change in the next release?

Main impact is that current view edition system automatically load to the last version with the same major number.

@targos
Copy link
Collaborator Author

targos commented Mar 12, 2026

Luc told me that he wants to remove Onde from all views that still use it.

I let you decide if you want to release as major, but for me it's hard to consider this not major.

@targos targos merged commit a5d1bb3 into master Mar 12, 2026
6 checks passed
@targos targos deleted the rm-more-modules branch March 12, 2026 15:56
@stropitek
Copy link
Collaborator

Doing a major release SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants