Skip to content

[develop] Fix the meta gempak job so it can run in production mode#4711

Open
DavidHuber-NOAA wants to merge 12 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:feature/realtime_meta
Open

[develop] Fix the meta gempak job so it can run in production mode#4711
DavidHuber-NOAA wants to merge 12 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:feature/realtime_meta

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Mar 26, 2026

Description

The gempak meta job, when run in production, is intended to run alongside the GFS forecast and run as different forecast intervals are passed. This capability was not tested during development and this PR fixes it.

Refs #4436

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Ran the gempakmeta job in a production-like manner within the C96_atm3DVar_extended test.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • (NO, this must be run separately) This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA DavidHuber-NOAA changed the title Fix the meta gempak job so it can run in production mode [develop] Fix the meta gempak job so it can run in production mode Apr 6, 2026
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review April 6, 2026 13:54
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

I have tested this in a production-like configuration and shown that the gempakmeta job now runs correctly in that manner. Opening for review.

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

Both extended tests passed on WCOSS2 in both production-like and development modes.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Passed (CM) Manual CI testing on WCOSS for this PR has completed successfully label Apr 6, 2026
@ChristopherHill-NOAA
Copy link
Copy Markdown
Contributor

Thank you for the update, @DavidHuber-NOAA. I will complete my review for this PR on Wednesday (04/08).
cc: @sbanihash

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you @ChristopherHill-NOAA!

Comment on lines 33 to 35
if [[ "${fhend}" -gt "${FHMAX_GFS}" ]]; then
export fhend="${FHMAX_GFS}"
fi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This existing if-block may be redundant with the if-block in new file config.gempakmeta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Wcoss2-Passed (CM) Manual CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants