[develop] Fix the meta gempak job so it can run in production mode#4711
Open
DavidHuber-NOAA wants to merge 12 commits intoNOAA-EMC:developfrom
Open
[develop] Fix the meta gempak job so it can run in production mode#4711DavidHuber-NOAA wants to merge 12 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA wants to merge 12 commits intoNOAA-EMC:developfrom
Conversation
Contributor
Author
|
I have tested this in a production-like configuration and shown that the gempakmeta job now runs correctly in that manner. Opening for review. |
Contributor
Author
|
Both extended tests passed on WCOSS2 in both production-like and development modes. |
Contributor
|
Thank you for the update, @DavidHuber-NOAA. I will complete my review for this PR on Wednesday (04/08). |
Contributor
Author
|
Thank you @ChristopherHill-NOAA! |
Comment on lines
33
to
35
| if [[ "${fhend}" -gt "${FHMAX_GFS}" ]]; then | ||
| export fhend="${FHMAX_GFS}" | ||
| fi |
Contributor
There was a problem hiding this comment.
This existing if-block may be redundant with the if-block in new file config.gempakmeta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gempak meta job, when run in production, is intended to run alongside the GFS forecast and run as different forecast intervals are passed. This capability was not tested during development and this PR fixes it.
Refs #4436
Type of change
Change characteristics
How has this been tested?
Ran the gempakmeta job in a production-like manner within the C96_atm3DVar_extended test.
Checklist