[develop] Do not load prod_util or run module reset when running ecflow#4657
Open
DavidHuber-NOAA wants to merge 4 commits intoNOAA-EMC:developfrom
Open
[develop] Do not load prod_util or run module reset when running ecflow#4657DavidHuber-NOAA wants to merge 4 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA wants to merge 4 commits intoNOAA-EMC:developfrom
Conversation
DavidHuber-NOAA
added
the
needs submodule update
DavidHuber-NOAA
changed the title
9 tasks
Contributor
Author
|
Opening PR for review. The companion GDASApp PR NOAA-EMC/GDASApp#2118 is currently in review. These PRs do not necessarily need to be coordinated, though NOAA-EMC/GDASApp#2118 must be merged first. |
DavidHuber-NOAA
requested review from
JessicaMeixner-NOAA,
RussTreadon-NOAA and
TravisElless-NOAA
as code owners
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Apr 10, 2026
# Description This PR introduces an if block to the WCOSS2 module file to prevent prod_util from loading when running an ecflow case. This is necessary to prevent certain variables from getting clobbered and so prod_util can be loaded in the .ecf script (which is the standard). # Issues Refs NOAA-EMC/global-workflow#4599 This is a prerequisite for NOAA-EMC/global-workflow#4657 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [x] atm_jjob <!-- JEDI atm single cycle DA !--> - [x] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [x] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [x] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [x] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA !--> - [x] C48_ufsenkf_atmDA <!-- JEDI atm EnKF cycled DA !--> - [x] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running an ecflow suite, some modules need to be loaded in the ecf scripts and never unloaded (including prod_util). This change this change works to prevent either of these from happening.
Refs #4599
Type of change
Change characteristics
How has this been tested?
Loaded modules on WCOSS2 with and without
ECF_JOBdefined. Lin will be testing this in a parallel.Checklist