Merged
Conversation
chrisroos
force-pushed
the
use-yarn-1-in-tool-versions
branch
from
aa2529e to
b31ef22
Compare
thomasleese
approved these changes
Apr 23, 2026
benilovj
approved these changes
Apr 23, 2026
misaka
approved these changes
Apr 23, 2026
misaka
force-pushed
the
use-yarn-1-in-tool-versions
branch
from
b31ef22 to
739942a
Compare
PR #6612 added yarn to .tool-versions instead of specifying that it should be installed using homebrew. The version you get when installing using homebrew is 1.22.22[1] ("Yarn classic") while the version added to .tool-versions was 4.9.4 ("Yarn modern"). I've opened a draft PR[2] to follow the migration guide to upgrade to Yarn modern but it seems like it might be a bit involved. In the meantime all the developers will start to see changes to .package.json and the addition of new yarn related files when they run `yarn install`. I think it's safer for now to retain the behaviour prior to #6612 while we work on #6681 in the background. [1]: https://formulae.brew.sh/formula/yarn [2]: #6681
misaka
force-pushed
the
use-yarn-1-in-tool-versions
branch
from
739942a to
4918e6d
Compare
Collaborator
|
Further explanation from @chrisroos on why the change in #6612 breaks things, but why that wasn't evident in the PRs checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6612 added yarn to .tool-versions instead of specifying that it should be installed using homebrew. The version you get when installing using homebrew is 1.22.22 ("Yarn classic") while the version added to .tool-versions was 4.9.4 ("Yarn modern"). I've opened a draft PR to follow the migration guide to upgrade to Yarn modern but it seems like it might be a bit involved. In the meantime all the developers will start to see changes to .package.json and the addition of new yarn related files when they run
yarn install. I think it's safer for now to retain the behaviour prior to #6612 while we work on #6681 in the background....
Jira Issue - MAV-6706