Open
Conversation
We will allow users to edit the phase of a school as the information from GIAS is often out-dated/incorrect. We would still want to track GIAS phase as a source of truth so we add a new column to the model instead of overriding the existing one.
Use overriden value where present, else default to gias_phase
Add a "Change" link from the school edit screen for the Phase value. Users can choose from one of the four default phase groups.
murugapl
force-pushed
the
edit-school-phase
branch
from
8da82dd to
9c25c08
Compare
thomasleese
reviewed
Apr 23, 2026
| }, | ||
| value: { | ||
| text: schoolable.human_enum_name(:phase) | ||
| text: Location.human_enum_name(:phase, schoolable.phase) |
Contributor
There was a problem hiding this comment.
I prefer how the old code looks, what's the reason for this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "Change" link from the school edit screen for the Phase value. Users can choose from one of the four default phase groups. Users will also have to select phase when adding a school or creating a site.
Jira Issue - MAV-7087
Screenshots