Add ability to present Managed Identity derived bearer token#96
Merged
Add ability to present Managed Identity derived bearer token#96
Conversation
steventux
force-pushed
the
feat/acquire-managed-identity-token
branch
from
f1f6061 to
3e8c34a
Compare
|
|
||
| @property | ||
| def access_token(self) -> str: | ||
| resource = os.getenv("CLOUD_API_RESOURCE") |
Contributor
There was a problem hiding this comment.
is there a case for differentiating between 'production' and 'development' environments, where a prod env unambiguously mandates the presence of CLOUD_API_RESOURCE
carlosmartinez
approved these changes
Apr 16, 2026
Contributor
carlosmartinez
left a comment
carlosmartinez
left a comment
There was a problem hiding this comment.
happy with this. at some point we should think about how a production-type environment differs from a non-production environment.
Open
2 tasks
steventux
force-pushed
the
feat/acquire-managed-identity-token
branch
3 times, most recently
from
056ddae to
2f6e1dd
Compare
steventux
force-pushed
the
feat/acquire-managed-identity-token
branch
from
2f6e1dd to
e1255a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
System assigned managed identity is provided on the gateway via Azure Arc.
We should use this to fetch the access token used in API communication. We can then validate on the Manage side.
Requires the presence of
CLOUD_API_RESOURCEenv var. This is an assumption based on azure sdk docs for ManagedIdentityCredential#get_token.Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12648
Review notes
Review checklist