Skip to content

feat(module:modal): support global nzCentered configuration#9455

Open
keke521jie wants to merge 1 commit intoNG-ZORRO:masterfrom
keke521jie:feat/close-7458
Open

feat(module:modal): support global nzCentered configuration#9455
keke521jie wants to merge 1 commit intoNG-ZORRO:masterfrom
keke521jie:feat/close-7458

Conversation

@keke521jie
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

close #7458
Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (75589bd) to head (d959488).
⚠️ Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9455      +/-   ##
==========================================
+ Coverage   90.73%   90.86%   +0.13%     
==========================================
  Files         561      575      +14     
  Lines       22847    23272     +425     
  Branches     4543     4642      +99     
==========================================
+ Hits        20730    21147     +417     
+ Misses       1407     1396      -11     
- Partials      710      729      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nicoss54
Copy link
Copy Markdown
Collaborator

lint failed and build too ? Could you fix please ?

@keke521jie
Copy link
Copy Markdown
Contributor Author

lint failed and build too ? Could you fix please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Modal nzCentered in default config, or just default it to true

4 participants