feat(module:table): use nzCustomColumn to hide columns without using width and flex css property#8891
Open
sharakouze wants to merge 3 commits intoNG-ZORRO:masterfrom
Open
feat(module:table): use nzCustomColumn to hide columns without using width and flex css property#8891sharakouze wants to merge 3 commits intoNG-ZORRO:masterfrom
sharakouze wants to merge 3 commits intoNG-ZORRO:masterfrom
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8891 +/- ##
==========================================
+ Coverage 91.89% 91.90% +0.01%
==========================================
Files 546 555 +9
Lines 19291 19712 +421
Branches 2850 2946 +96
==========================================
+ Hits 17728 18117 +389
- Misses 1251 1267 +16
- Partials 312 328 +16 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@OriginRing Please take a look |
Contributor
Author
|
@OriginRing > any news ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I don't like the way nzCustomColumn works actually because it forces me to provide a width for those columns.
I just want to hide some columns, without defining width and without using flex css property.
Issue Number: N/A
What is the new behavior?
I've done this using the nzCustomColumn property but if you prefer I can do this by creating a new property (nzHiddenColumns for example)
If you set "hidden" property instead of "default" in nzCustomColumn, the NzCustomColumnDirective will just set display: none for cells you want to be hidden
Does this PR introduce a breaking change?
Other information