feat(module:anchor): url fragment change on click - nzReplace#8464
feat(module:anchor): url fragment change on click - nzReplace#8464ParsaArvanehPA wants to merge 36 commits intoNG-ZORRO:masterfrom
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8464 +/- ##
==========================================
- Coverage 91.83% 91.81% -0.02%
==========================================
Files 548 548
Lines 19310 19320 +10
Branches 2862 2865 +3
==========================================
+ Hits 17733 17739 +6
- Misses 1261 1262 +1
- Partials 316 319 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
unit tests failed with error, please solve this issue first @ParsaArvanehPA anchor property (nzChange) should emit nzChange when scrolling to the anchor |
…ttps://github.com/ParsaArvanehPA/ng-zorro-antd into feature/anchor-navigation-without-location-change
@ParsaArvanehPA I had tried to fix this CI issue, but all my efforts didn't work. Your previous workaround which is to multiply the throttleTime by 20 FAILs. |
Thanks @Laffery |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
replaceoption that Ant provides.What is the new behavior?
Does this PR introduce a breaking change?
Other information