Draft
Conversation
Move representative_mesh_dimensions to AutomaticMesh
Add representative mesh dimensions
Move representative mesh logic to HABC_Mesh
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 80.35% 80.64% +0.29%
==========================================
Files 84 85 +1
Lines 7237 7352 +115
==========================================
+ Hits 5815 5929 +114
- Misses 1422 1423 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add a new MeshOps class (spyro/meshing/meshing_operations.py) that encapsulates mesh-related utilities (e.g. representative_mesh_dimensions, point-cloud helpers, masking and extension helpers).
Centralize mesh dimensions and coords
Trim trailing whitespace and drop unused import
Refactor MeshOps and add boundary ID mapping
Refactor mesh node extraction and boundary mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first change that it should be reviewed to infer if makes sense