Fix eslint issues in components used for the file hierarchy table#2659
Merged
rushirajnenuji merged 4 commits intodevelopfrom Jul 16, 2025
Merged
Fix eslint issues in components used for the file hierarchy table#2659rushirajnenuji merged 4 commits intodevelopfrom
rushirajnenuji merged 4 commits intodevelopfrom
Conversation
Return the view from render rather than initialize to keep the view consistent with the rest of the codebase. Issue #2483
- Left a few tricker ones since this model will be deprecated - Removed unused methods: getMemberNames, getProvTrace, getMemberNames, getExternalProvTrace, sortProvTrace, setMemberProvTrace - Added JS docs to make it clear that the intention is to deprecate this model Issue #2483
7 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rushirajnenuji
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed linting in the following files:
src/js/views/DataItemView.jssrc/js/views/DataPackageView.jssrc/js/views/DownloadButtonView.jssrc/js/views/MetadataView.jssrc/js/collections/DataPackage.jssrc/js/models/PackageModel.jsPackageModelhas a few linting errors left but the plan is to deprecate it so it's better just to leave them.Changes also include:
Closes #2483