Skip to content

registry-api 406: change to wildcard#469

Closed
al-niessner wants to merge 10 commits intodevelopfrom
api-406
Closed

registry-api 406: change to wildcard#469
al-niessner wants to merge 10 commits intodevelopfrom
api-406

Conversation

@al-niessner
Copy link
Contributor

🗒️ Summary

The definition of a and how a wildcard is handled was updated. Had to fix some of the tests to match the new definition.

⚙️ Test Data and/or Report

Postman test work with registry-api that have the wildcard updates.

♻️ Related Issues

Part of #NASA-PDS/registry-api#723

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

  • Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@tloubrieu-jpl
Copy link
Member

Hi @al-niessner , I missed to tell you that the default branch is now develop in the registry repository. I am not sure but you might have pulled from the main branch or maybe used an outdated version of the develop branch. Do you mind to resolve the merge conflict on your side.

No hurry though, I should be able to pull your tests anyway for the demo tomorrow.

Thanks

@tloubrieu-jpl
Copy link
Member

@al-niessner , I also noticed that the PR removes tests instead of updating them to work with the latest version of the code.

Note also that the reference dataset has also been updated so the number of properties should be 170.

@al-niessner
Copy link
Contributor Author

al-niessner commented Jan 27, 2026 via email

@al-niessner
Copy link
Contributor Author

This is a mess up on my part. Simpler to redo work than to try and "fix" merge.

@al-niessner al-niessner deleted the api-406 branch January 28, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants