Closed
Conversation
…or a dev version of the API
9 tasks
Member
|
Hi @al-niessner , I missed to tell you that the default branch is now No hurry though, I should be able to pull your tests anyway for the demo tomorrow. Thanks |
Member
|
@al-niessner , I also noticed that the PR removes tests instead of updating them to work with the latest version of the code. Note also that the reference dataset has also been updated so the number of properties should be 170. |
Contributor
Author
|
I bet i forgot to export them...
…On Tue, Jan 27, 2026, 3:23 PM thomas loubrieu ***@***.***> wrote:
*tloubrieu-jpl* left a comment (NASA-PDS/registry#469)
<#469 (comment)>
@al-niessner <https://github.com/al-niessner> , I also noticed that the
PR removes tests instead of updating them to work with the latest version
of the code.
Note also that the reference dataset has also been updated so the number
of properties should be 170.
—
Reply to this email directly, view it on GitHub
<#469 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUBIXKWWTK7YYO4RVFN5T4I7XNHAVCNFSM6AAAAACTC36IMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBYGA4DEMJUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
This is a mess up on my part. Simpler to redo work than to try and "fix" merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The definition of a and how a wildcard is handled was updated. Had to fix some of the tests to match the new definition.
⚙️ Test Data and/or Report
Postman test work with registry-api that have the wildcard updates.
♻️ Related Issues
Part of #NASA-PDS/registry-api#723
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Security & Quality
Testing & Validation
Documentation
Maintenance