upnp: defer cleanup for HTTP status errors - #2577
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
Deleting the device description downloader from OnHeaders() frees the CurlResponseHandlerAdapter while DataReceived() still uses it. A UPnP server can trigger a use-after-free by returning a non-200 response with body data. Throw HttpStatusError so the adapter defers cleanup until OnError().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UPnP device description downloader deleted itself from
OnHeaders()when a server returned a non-200 status.CurlResponseHandlerAdapterthen continuedDataReceived()and calledOnData()through the deleted request, causing a use-after-free. A UPnP server on the local network can trigger this when the UPnP database or neighbor plugin is enabled.Throw
HttpStatusErrorinstead. The curl adapter records the exception, aborts the transfer, and invokesOnError()after leaving the data callback, where the downloader can be destroyed safely.