Fix treesitter modes icons missing#109
Open
p1k0chu wants to merge 1 commit intoMstrodl:masterfrom
Open
Conversation
use derived-mode-all-parents to get a list of all parents including extra ones. this allows all (sane) tree-sitter modes to resolve their icons correctly
|
would be nice to have treesit modes to this :) |
Owner
|
Sorry I let this sit for so long. I'll try and test this so I can merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tree sitter modes, at least built-in ones, add the usual mode as an extra parent.
but the main parent is something else, like prog-mode or ruby-base-mode, so elcord fails to find an icon.
this change updates elcord--mode-icon to use derived-mode-all-parents to use all parents including extra ones, when looking for icon