Skip to content

feat(covmanager): modify all report filters to be case insensitive #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyoor merged 1 commit into from
Jan 16, 2026
Merged

feat(covmanager): modify all report filters to be case insensitive #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions server/covmanager/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def tools_search_api(request):

if "name" in request.GET:
name = request.GET["name"]
results = Tool.objects.filter(name__contains=name).values_list(
results = Tool.objects.filter(name__icontains=name).values_list(
"name", flat=True
)

Expand Down Expand Up @@ -669,15 +669,15 @@ def filter_queryset(self, request, queryset, view):

filters = {}
exactFilterKeys = [
"description__contains",
"description__icontains",
"repository__name",
"repository__name__contains",
"repository__name__icontains",
"revision",
"revision__contains",
"revision__icontains",
"branch",
"branch__contains",
"branch__icontains",
"tools__name",
"tools__name__contains",
"tools__name__icontains",
]

for key in exactFilterKeys:
Expand Down
15 changes: 9 additions & 6 deletions server/frontend/src/components/Covmanager/Collections.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,11 @@ export default defineComponent({
search_initialized: false,

search: {
branch: { value: "", contains: true },
description: { value: "", contains: true },
repository: { value: "", contains: true, postfix: "__name" },
revision: { value: "", contains: true },
tools: { value: "", contains: true, postfix: "__name" },
branch: { value: "", icontains: true },
description: { value: "", icontains: true },
repository: { value: "", icontains: true, postfix: "__name" },
revision: { value: "", icontains: true },
tools: { value: "", icontains: true, postfix: "__name" },
limit: { value: "10", contains: false },
},

Expand Down Expand Up @@ -281,6 +281,7 @@ export default defineComponent({
// TODO: This is a shortcut that saves us iterating through this.search
// for every key that we are trying to map to a field in our search
// object, but this won't work once we have more postfixes.
k = k.replace(/__icontains$/, "");
k = k.replace(/__contains$/, "");
k = k.replace(/__name$/, "");

Expand All @@ -304,7 +305,9 @@ export default defineComponent({
k += obj.postfix;
}

if ("contains" in obj && obj.contains) {
if ("icontains" in obj && obj.icontains) {
k += "__icontains";
} else if ("contains" in obj && obj.contains) {
k += "__contains";
}

Expand Down