Adjust when we build for code coverage when it isn't enabled#3257
Merged
brentleyjones merged 1 commit intoMobileNativeFoundation:mainfrom Dec 17, 2025
Merged
Conversation
Signed-off-by: Aaron Sky <aaronsky@skyaaron.com>
adincebic
approved these changes
Dec 17, 2025
Contributor
adincebic
left a comment
adincebic
left a comment
There was a problem hiding this comment.
Thanks for addressing this.
Contributor
|
CC @ghugues |
brentleyjones
approved these changes
Dec 17, 2025
brentleyjones
merged commit 3755557
into
MobileNativeFoundation:main
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3255 (partially)
For builds where code coverage is not enabled in the scheme's test action, do not build with coverage. Should reduce thrash in index builds and address a regression in the cache performance of Xcode builds that hadn't opted into this feature.
Note: this does not fix the issue for build-for-running builds of tests, as we have no clear-cut way of differentiating between build-for-running and build-for-testing in the BazelDependencies run script phase. Open to other ideas, since this is based on undocumented xcodebuild behavior and is not super-nice.