Fix an rsync issue causing "Permission denied" errors

[thiagohmcruz]

Follow up to #3175

Note: this issue seems related

[thiagohmcruz]

Do we want to do this unconditionally or per OS version? Lacking some context about the previous PR adding --perms so wanted to confirm

[thiagohmcruz]

cc @luispadron @brentleyjones when you're available I'd appreciate if you could clarify please 🙇

[brentleyjones]

I don't think we want a version check.

[iMostfa]

for some reason i'm still facing rsync(6413): error: mkstempat
on latest release, and even when testing your branch 15.4.1 (24E263)

[thiagohmcruz]

for some reason i'm still facing rsync(6413): error: mkstempat on latest release, and even when testing your branch 15.4.1 (24E263)

@iMostfa are you able to provide a repro for this? Maybe a small zipped project or using of the examples in rules_xcodeproj? Maybe the project I used to repro this is missing an edge case 🤔

[iMostfa]

@thiagohmcruz
i tried to make a small repo to reproduce, but for some reason, it works on a small project, but not on my main project.

is there anything else i can do to help you debug the issue ?

[thiagohmcruz]

@thiagohmcruz i tried to make a small repo to reproduce, but for some reason, it works on a small project, but not on my main project.

is there anything else i can do to help you debug the issue ?

@iMostfa there's an ongoing discussion in the Bazel slack, some folks finding issues in their internal setup as well, maybe check that thread and see if it helps?

I'm holding this PR for now as I'm not sure if it's fully addressing the issue. I'll have to run more tests to verify that, thx for the help so far!

[thiagohmcruz]

It seems like there's a fix in the works, closing this for now.

[brentleyjones]

I don't think the homebrew path is a long term fix. It would be nice to have a different reliable route if possible.

[thiagohmcruz]

@iMostfa it would be great to get a repro here, have you tried using the examples in the repo? Otherwise the only path forward I see is to dig more into your internal setup and try to isolate the issue