feat: Add resume position tracking for all play types#2331
Draft
hoffie wants to merge 1 commit intoMiczFlor:future3/developfrom
Draft
feat: Add resume position tracking for all play types#2331hoffie wants to merge 1 commit intoMiczFlor:future3/developfrom
hoffie wants to merge 1 commit intoMiczFlor:future3/developfrom
Conversation
Pull Request Test Coverage Report for Build 8653786800Details
💛 - Coveralls |
s-martin
reviewed
Apr 11, 2024
hoffie
force-pushed
the
add-play-position-tracking
branch
from
317673c to
dbfe64f
Compare
hoffie
changed the title
Merged
pabera
changed the title
hoffie
force-pushed
the
add-play-position-tracking
branch
from
dbfe64f to
07e9ea8
Compare
The tracking is active by default, but the resuming has to be enabled explicitly, either by setting playermpd.resume.resume_by_default: true or by calling the play_* functions with the new resume=True kwarg. Related: MiczFlor#1946
hoffie
force-pushed
the
add-play-position-tracking
branch
from
07e9ea8 to
9c94056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracking is active by default, but the resuming has to be enabled explicitly, either by setting
playermpd.play_position_tracking.resume_by_default: trueor by calling the play_* functions with the new resume=True kwarg.
Related: #1946
Reasons for draft status / checklist before merging:
I've been using most of the code on my Phoniebox without problems. The code has seen some adjustments by now though, so it hasn't been tested as-is. Other than that, it's ready for review. I will do a final round of testing when the reviews are done.
Previous review by @pabera (most of the actionable items should have been incorporated by now): hoffie@c4805ce