Open
Conversation
…1182 and combined it with random subfolder play (MiczFlor#1175). Also added the possibility to play all or just a single subfolder.
Author
|
Hi all, just added skip subfolder functionality as requested in #1182 Unfortunately, it required some more mangling with rfid_trigger_play.sh, but it should not be noticed by surroundings. |
Karli2727
suggested changes
Aug 10, 2022
Karli2727
left a comment
Karli2727
left a comment
There was a problem hiding this comment.
scripts/rfid_trigger_play.sh
Line 516 - missing second ">" , therefore subfolder play won't start.
Collaborator
Thanks for your comment. |
s-martin
reviewed
Apr 8, 2024
| # replace subfolder slashes with " % " | ||
| PLAYLISTPATH="${PLAYLISTSFOLDERPATH}/${FOLDER//\//\ %\ }.m3u" | ||
| PLAYLISTNAME="${FOLDER//\//\ %\ }" | ||
| echo "" > "${PLAYLISTPATH}" |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "" > "${PLAYLISTPATH}" | |
| echo "" >> "${PLAYLISTPATH}" |
Collaborator
Added https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/1175/files#r1556369182 |
Nexodaru
pushed a commit
to Nexodaru/RPi-Jukebox-RFID
that referenced
this pull request
Apr 2, 2025
…, MiczFlor#1175) Added functionality to skip to next subfolder as requested in MiczFlor#1182 and combined it with random subfolder play (MiczFlor#1175). Also added the possibility to play all or just a single subfolder.
Nexodaru
pushed a commit
to Nexodaru/RPi-Jukebox-RFID
that referenced
this pull request
Apr 2, 2025
…, MiczFlor#1175) Added functionality to skip to next subfolder as requested in MiczFlor#1182 and combined it with random subfolder play (MiczFlor#1175). Also added the possibility to play all or just a single subfolder.
Nexodaru
added a commit
to Nexodaru/RPi-Jukebox-RFID
that referenced
this pull request
Apr 2, 2025
…, MiczFlor#1175) (#2) * Added functionality to play random subdirectory ans skip (MiczFlor#1182, MiczFlor#1175) Added functionality to skip to next subfolder as requested in MiczFlor#1182 and combined it with random subfolder play (MiczFlor#1175). Also added the possibility to play all or just a single subfolder. --------- Co-authored-by: matthias-pelger <matthias.pelger@t-online.de>
Nexodaru
added a commit
to Nexodaru/RPi-Jukebox-RFID
that referenced
this pull request
Apr 7, 2025
…zFlor#1182, MiczFlor#1175) (#2)" This reverts commit 88d33ce.
Nexodaru
added a commit
to Nexodaru/RPi-Jukebox-RFID
that referenced
this pull request
Apr 7, 2025
…, MiczFlor#1175) (#2) * Added functionality to play random subdirectory ans skip (MiczFlor#1182, MiczFlor#1175) Added functionality to skip to next subfolder as requested in MiczFlor#1182 and combined it with random subfolder play (MiczFlor#1175). Also added the possibility to play all or just a single subfolder. --------- Co-authored-by: matthias-pelger <matthias.pelger@t-online.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for improvement:
See #1170
Missing functionality to play a random subfolder when a card is assigned to the top folder and the conf is set accordingly.
Proposal:
Minor changes and additions necessary.
Possible breaking change: changed logic to check for second swipe: Instead to check for LASTPLAYLIST now LASTID is used. LASTID is basically the folder from CARDID, separating the really played folder from the one assigned to the card.
Beside this, the LASTPLAYLIST is still there and being set. I think this will not break anything and still enable a thourough secondswipe check.
Backend
New parameter introduced in "folder.conf", FOLDERSHUFFLE to save setting for folder. Also used in WebUI.
The button is shown if there is at least one subfolder. With this button, also a new api file is introduced.