Skip to content

Fix clippy uninlined_format_args warnings after anyhow bump#36

Merged
Mic92 merged 3 commits intodependabot/cargo/anyhow-1.0.100from
copilot/sub-pr-10
Dec 24, 2025
Merged

Fix clippy uninlined_format_args warnings after anyhow bump#36
Mic92 merged 3 commits intodependabot/cargo/anyhow-1.0.100from
copilot/sub-pr-10

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 24, 2025

  • Understand the clippy errors from CI
  • Fix uninlined_format_args in src/instantiate.rs:122
  • Fix uninlined_format_args in src/parser.rs:295
  • Fix uninlined_format_args in src/main.rs:62
  • Fix uninlined_format_args in src/parser.rs:268
  • Verify clippy passes on all targets
  • Verify unit tests pass

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Mic92 <96200+Mic92@users.noreply.github.com>
Copilot AI changed the title [WIP] Update anyhow to version 1.0.100 Fix clippy uninlined_format_args warnings after anyhow bump Dec 24, 2025
Copilot AI requested a review from Mic92 December 24, 2025 08:07
@Mic92
Copy link
Copy Markdown
Owner

Mic92 commented Dec 24, 2025

@copilot

mmjq815xywn3izz377s71q0s0n1y15ax-nix-diff-0.1.0.drv'.
Reason: builder failed with exit code 101.
Output paths:
/nix/store/yzv1ddnm1ipbdwdy41n3375gh0d4yxcj-nix-diff-0.1.0
Last 25 log lines:
> Compiling serde_derive v1.0.219
> Checking regex v1.11.1
> Checking ciborium v0.2.2
> Checking tinytemplate v1.2.1
> Checking criterion v0.6.0
> Checking tikv-jemallocator v0.6.0
> Checking nix-diff v0.1.0 (/nix/var/nix/builds/nix-47199-712823280/msgqjvf103jsf76r14a5x8wnd3rvia3k-source)
> error: variables can be used directly in the format! string
> --> src/main.rs:62:32
> |
> 62 | return Err(anyhow!("Unknown option: {}", arg));
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
> = note: -D clippy::uninlined-format-args implied by -D warnings
> = help: to override -D warnings add #[allow(clippy::uninlined_format_args)]
> help: change this to
> |
> 62 - return Err(anyhow!("Unknown option: {}", arg));
> 62 + return Err(anyhow!("Unknown option: {arg}"));
> |
>
> error: could not compile nix-diff (bin "nix-diff" test) due to 1 previous error
> warning: build failed, waiting for other jobs to finish...
> error: could not compile nix-diff (bin "nix-diff") due to 1 previous error
For full logs, run:
nix log /nix/store/mmjq815xywn3izz377s71q0s0n1y15ax-nix-diff-0.1.0.drv
error: Cannot build '/nix/store/mmjq815xywn3izz377s71q0s0n1y15ax-nix-diff-0.1.0.drv'.
Reason: builder failed with exit code 1.
Output paths:
/nix/store/yzv1ddnm1ipbdwdy41n3375gh0d4yxcj-nix-diff-0

Co-authored-by: Mic92 <96200+Mic92@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Dec 24, 2025

@copilot

mmjq815xywn3izz377s71q0s0n1y15ax-nix-diff-0.1.0.drv'.
...

Fixed the remaining clippy warning in src/main.rs:62 and found one more in src/parser.rs:268. All clippy warnings are now resolved. Changes made in commit 01395c9.

@Mic92 Mic92 marked this pull request as ready for review December 24, 2025 08:43
@Mic92 Mic92 merged commit 6d3a12a into dependabot/cargo/anyhow-1.0.100 Dec 24, 2025
3 checks passed
@Mic92 Mic92 deleted the copilot/sub-pr-10 branch December 24, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants