Open
Conversation
* chore: bump anchor v1 * fix: ci * fix: ci * fix: rebase mistake * fix: ci again * fix: bot review * chore: reduce import * minor fix (#202) * fix: comments * fix: use official anchor tag for security, but contains event_cpi warning * chore: update readme test script --------- Co-authored-by: andrewsource147 <31321699+andrewsource147@users.noreply.github.com>
…r program PDA) (#199) * release_0.2.1 * feat/claim protocol fee unchecked * feat: add new error * feat: fix claim protocol fee - remove claim protocl fee unchecked - remove zap protocol fee * refactor: separate pda from external program * refactor: cleanup * feat: add both token mint acounts * feat: rename claim_protocol_fee2 * feat: re-add claim_protcol_fee and zap_protocol_fee - update zap.so to 0.2.2 * fix: move tests to its own dedicated files * fix: bot review commenta * docs: update changelog * feat: address comments * fix: remove duplicate test * feat: address comments - consistent account order - remove event_cpi * feat: check exclude transfer fee amount - add comment for emit! log could be truncated * fix: after rebase. add missing test * fix: after rebasing
Contributor
|
Vault review note (severity: Low / Consistency)\n\n includes a good Token-2022 transfer-fee guard ( + non-zero check) before transfer.\n\nRequest: please keep this as the reference behavior and align companion repos/instructions to the same claim semantics, so protocol fee accounting is consistent across Meteora programs for transfer-fee mints.\n\nNo blocker from this item on cp-amm itself. |
Contributor
|
Correction / precise reference: the guard exists in programs/cp-amm/src/instructions/operator/ix_claim_protocol_fee2.rs (calculate_transfer_fee_excluded_amount + require(amount>0) before transfer). No blocker from this item on cp-amm itself; this is a cross-repo consistency reference. |
* fix: get nextSqrtPrice for compounding fee * fix: remove redundant CollectFeeMode parsing * feat: add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.