Open
Conversation
…n meteor-collection-hooks
…dependency in tests-app
…ntext tests in publish.test.js due to v2.0.0 changes.
…` instead of `_super`. Introduce constants for async methods and MongoDB operators for better readability and maintainability.
… methods to prevent recursion.
… instead of current directory
Member
|
hey @harryadel anything you need here to move on? |
Member
Author
|
I was hoping to gather some feedback from the community but nobody chimed in 🤷 we could pull the trigger nonetheless |
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jankapunkt
approved these changes
Dec 30, 2025
Member
|
massive PR @harryadel !!! @StorytellerCZ from my end this looks good but I can't field test the rc until next week, do you have the resources for that? |
Member
|
I'm busy till next week for anything big as well. |
Member
Author
|
@StorytellerCZ I can wait things out for sure but I'd definitely need you to have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failing server side tests
Fix linting
Verify .find hooks workHistory & README were updated to properly reflect the current package status
Support both sync and async operations in all hooksAs I was working on the package I thought it'd be possible to support async operations in sync hooks but I then figured how hard it'd be to support such a thing as blocking sync execution based on a sync operation wouldn't be feasible and allowing async operations as fire-and-forget to not block things would be awkward. I know understand why @bhunjadi decided to drop sync support and now hooks are only triggered on async operations (ex:
findOneAsyncinstead offindOne)Async hook started // ← Hook fires immediately findOne returned: {_id: 1, name: 'John'} // ← findOne completes WITHOUT waiting Async hook finished // ← Hook completes later (200ms later)Fix CI tests
Utilize https://packosphere.com/lai/collection-extensions until Integrate lai:collection-extensions into core meteor/meteor#13830 gets merged
Once it's ready, ping @vparpoil for one last test
Post release