Empty / pre-CP-reveal audit for the new side-by-side row by ncarazon · Pull Request #4700 · Metaculus/metaculus

ncarazon · 2026-05-07T17:27:36Z

Summary

This PR audits and fixes the three hidden-CP states - user preference (hideCP), pre-reveal time (cpRevealsOn), and no forecasts yet (isEmpty) - across the new side-by-side question layout introduced in the previous PR.

Implemented fixes:

Continuous left panel (QuestionHeaderCPStatus): restructured into three early-return states - empty outline box with a centered "Current estimate" label when isEmpty, centered UpcomingCP countdown when cpRevealsOn, centered RevealCPButton when hideCP - so the column width is always preserved and the correct state is always shown
Binary left panel (QuestionHeaderCPStatus): added hideCP early return that renders a centered RevealCPButton inside the fixed-width container for both forecaster desktop and mobile
Consumer continuous mobile (ContinuousQuestionPrediction): added hideCP guard that replaces the mini-chart tile with a centered RevealCPButton on mobile
Consumer binary left card (question_page_shell/index.tsx): wired hideCP → RevealCPButton and cpRevealsOn → UpcomingCP in the shell, removing the need for downstream components to handle these states
Timeline hover cursor: suppressed the VictoryCursorContainer (replacing it with VictoryContainer) when hideCP or cpRevealsOn is active, so no hover line appears over a blank chart
Histogram duplicate button: removed the RevealCPButton rendered inside the histogram view - it duplicated the one already shown in the left panel
Title row overflow (title_row.tsx): fixed long or URL-heavy titles overflowing onto the CP status panel

Demo videos

Consumer view (desktop, mobile)

Empty state

1.mp4

Revealed on

2.mp4

Hidden CP

3.mp4

Other charts

4.mp4

Forecaster view (desktop, mobile)

Empty state

5.mp4

Revealed on

6.mp4

Hidden CP

7.mp4

Other charts

8.mp4

Consumer and Forecaster views (desktop, mobile)

Empty state with Top key factors placeholder

9.mp4

coderabbitai · 2026-05-07T17:27:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 787a66f9-619a-4633-904f-41ceea5fd037

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-07T17:40:40Z

Cleanup: Preview Environment Removed

The preview environment for this PR has been destroyed.

Resource	Status
🌐 Preview App	Deleted
🗄️ PostgreSQL Branch	Deleted
⚡ Redis Database	Deleted
🔧 GitHub Deployments	Removed
📦 Docker Image	Retained (auto-cleanup via GHCR policies)

Cleanup triggered by PR close at 2026-05-11T18:28:56Z

cemreinanc

LGTM with some comments, I may not have totally understood the implications so just double check these please.

… card for binary and continuous questions

…de layout left panel and fix title overflow onto the CP block

…forecaster title row and left panel

…itle row

… on the question detail page

…ype left panels for the side-by-side layout

…fix missing useMemo deps, and align binary cpRevealsOn state with continuous

ncarazon marked this pull request as ready for review May 8, 2026 15:22

ncarazon requested review from cemreinanc, elisescu, hlbmtc and lsabor May 8, 2026 15:22

cemreinanc approved these changes May 11, 2026

View reviewed changes

Comment thread front_end/src/components/charts/numeric_chart.tsx

Comment thread front_end/src/components/charts/numeric_chart.tsx

Comment thread ...ponents/question_view/forecaster_question_view/question_header/question_header_cp_status.tsx

ncarazon added 8 commits May 11, 2026 21:16

fix: handle hideCP, cpRevealsOn, and isEmpty in the side-by-side left…

6d9e518

… card for binary and continuous questions

fix: handle isEmpty, cpRevealsOn, and hideCP states in the side-by-si…

bfce4cf

…de layout left panel and fix title overflow onto the CP block

fix: refine mobile hidden-CP states for binary and continuous in the …

9002d76

…forecaster title row and left panel

fix: prevent CP status from being squeezed off-screen in the mobile t…

dc9c4e9

…itle row

fix: restore "No forecasts yet" overlay in feed cards and suppress it…

ec76af8

… on the question detail page

fix: wire hideCP, cpRevealsOn, and isEmpty states into all question-t…

3da6936

…ype left panels for the side-by-side layout

fix: replace hardcoded isEmpty:false with suppressEmptyOverlay prop, …

a40e40b

…fix missing useMemo deps, and align binary cpRevealsOn state with continuous

fix: correct import order in continuous_question_prediction.tsx

89df406

ncarazon force-pushed the feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row branch from ad9b7c1 to 89df406 Compare May 11, 2026 18:17

ncarazon merged commit c32cab0 into feat/question-page-redesign-2nd-iteration May 11, 2026
14 checks passed

ncarazon deleted the feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row branch May 11, 2026 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Empty / pre-CP-reveal audit for the new side-by-side row#4700

Empty / pre-CP-reveal audit for the new side-by-side row#4700
ncarazon merged 8 commits into
feat/question-page-redesign-2nd-iterationfrom
feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row

ncarazon commented May 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 7, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented May 7, 2026 •

edited

Loading

Uh oh!

cemreinanc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ncarazon commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Demo videos

Consumer view (desktop, mobile)

Forecaster view (desktop, mobile)

Consumer and Forecaster views (desktop, mobile)

Uh oh!

coderabbitai Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cleanup: Preview Environment Removed

Uh oh!

cemreinanc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ncarazon commented May 7, 2026 •

edited

Loading

coderabbitai Bot commented May 7, 2026 •

edited

Loading

github-actions Bot commented May 7, 2026 •

edited

Loading