Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
commented
Mar 10, 2026
ui/helpers/queries.ts
Outdated
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +49 -30)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| "no-optional-chaining": "off", | ||
| "no-rest-spread-properties": "off" | ||
| } | ||
| } |
There was a problem hiding this comment.
Unrelated oxlint config file accidentally committed
Low Severity
A 106-line .oxlintrc.json.txt file was added at the repository root, but the PR description only mentions bumping core-backend and refactoring queries. The .txt extension means oxlint won't use it as a config file, suggesting it's a personal draft or exploration artifact. No other file references it, and it's unrelated to the stated PR purpose.
|
Contributor
Builds ready [160fce7]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored multichain activity transaction queries to use apiClient query options directly and removed the now-redundant local query helper.
Bump core-backend
Changelog
CHANGELOG entry: chore: bump core-backend; refactor query
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches multichain activity transaction fetching by swapping to
apiClientinfinite-query options and adjusting enable/refetch behavior, which could impact activity list loading/caching. Also bumps@metamask/core-backend, which may introduce subtle runtime changes via updated transitive controller deps.Overview
Updates multichain Activity v2 transaction querying to use
apiClient.accounts.getV4MultiAccountTransactionsInfiniteQueryOptionsdirectly, removing the localhelpers/querieswrapper and updating related unit tests.The
useTransactionsQueryhook now explicitly controlsenabled/keepPreviousDataand addsrefetchOnMount/refetchOnWindowFocus, and prefetching uses the sameapiClientoptions (with a temporary@ts-expect-errorfor v5/v4 type mismatch).Separately bumps
@metamask/core-backendto^6.1.0(updating lockfile transitive versions) and adds an.oxlintrc.json.txtconfiguration file with most rules disabled exceptsort-importsandno-accumulating-spread.Written by Cursor Bugbot for commit 160fce7. This will update automatically on new commits. Configure here.