fix: metamask pay network picker #39608
Merged
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update signed label in activity.
matthewwalsh0
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +1 -1)
|
matthewwalsh0
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
matthewwalsh0
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [52dd427]
UI Startup Metrics (1337 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
matthewwalsh0
changed the title
matthewwalsh0
added
the
no-changelog
pedronfigueiredo
approved these changes
Jan 29, 2026
OGPoyraz
approved these changes
Jan 29, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
## **Description** - Disable outside click on PayWithModal to prevent nested modal conflicts with NetworkFilter - Show "Pending" label for signed transaction status (same as submitted) [](https://codespaces.new/MetaMask/metamask-extension/pull/?quickstart=1) ## **Changelog** CHANGELOG entry: null ## **Related issues** Related to: [#6499](MetaMask/MetaMask-planning#6499) ## **Manual testing steps** 1. Initiate a MetaMask Pay transaction 2. Click "Pay with" to open the modal 3. Click the network filter dropdown 4. Verify the modal doesn't close unexpectedly ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI behavior tweaks: status-label mapping is expanded and covered by tests, and the modal change only affects close behavior (potentially impacting expected dismissal UX). > > **Overview** > Updates `TransactionStatusLabel` to treat `TransactionStatus.signed` the same as other transient states, mapping it to *pending* (or *queued* when `isEarliestNonce` is false), and adds Jest coverage for the new signed-status behavior. > > Adjusts the MetaMask Pay `PayWithModal` to **not close on outside click** (`isClosedOnOutsideClick={false}`) to avoid nested modal conflicts when using the network filter dropdown. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 52dd427. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
## **Description** - Disable outside click on PayWithModal to prevent nested modal conflicts with NetworkFilter - Show "Pending" label for signed transaction status (same as submitted) [](https://codespaces.new/MetaMask/metamask-extension/pull/?quickstart=1) ## **Changelog** CHANGELOG entry: null ## **Related issues** Related to: [#6499](MetaMask/MetaMask-planning#6499) ## **Manual testing steps** 1. Initiate a MetaMask Pay transaction 2. Click "Pay with" to open the modal 3. Click the network filter dropdown 4. Verify the modal doesn't close unexpectedly ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI behavior tweaks: status-label mapping is expanded and covered by tests, and the modal change only affects close behavior (potentially impacting expected dismissal UX). > > **Overview** > Updates `TransactionStatusLabel` to treat `TransactionStatus.signed` the same as other transient states, mapping it to *pending* (or *queued* when `isEarliestNonce` is false), and adds Jest coverage for the new signed-status behavior. > > Adjusts the MetaMask Pay `PayWithModal` to **not close on outside click** (`isClosedOnOutsideClick={false}`) to avoid nested modal conflicts when using the network filter dropdown. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 52dd427. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
## **Description** - Disable outside click on PayWithModal to prevent nested modal conflicts with NetworkFilter - Show "Pending" label for signed transaction status (same as submitted) [](https://codespaces.new/MetaMask/metamask-extension/pull/?quickstart=1) ## **Changelog** CHANGELOG entry: null ## **Related issues** Related to: [#6499](MetaMask/MetaMask-planning#6499) ## **Manual testing steps** 1. Initiate a MetaMask Pay transaction 2. Click "Pay with" to open the modal 3. Click the network filter dropdown 4. Verify the modal doesn't close unexpectedly ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI behavior tweaks: status-label mapping is expanded and covered by tests, and the modal change only affects close behavior (potentially impacting expected dismissal UX). > > **Overview** > Updates `TransactionStatusLabel` to treat `TransactionStatus.signed` the same as other transient states, mapping it to *pending* (or *queued* when `isEarliestNonce` is false), and adds Jest coverage for the new signed-status behavior. > > Adjusts the MetaMask Pay `PayWithModal` to **not close on outside click** (`isClosedOnOutsideClick={false}`) to avoid nested modal conflicts when using the network filter dropdown. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 52dd427. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.17.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: null
Related issues
Related to: #6499
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI behavior tweaks: status-label mapping is expanded and covered by tests, and the modal change only affects close behavior (potentially impacting expected dismissal UX).
Overview
Updates
TransactionStatusLabelto treatTransactionStatus.signedthe same as other transient states, mapping it to pending (or queued whenisEarliestNonceis false), and adds Jest coverage for the new signed-status behavior.Adjusts the MetaMask Pay
PayWithModalto not close on outside click (isClosedOnOutsideClick={false}) to avoid nested modal conflicts when using the network filter dropdown.Written by Cursor Bugbot for commit 52dd427. This will update automatically on new commits. Configure here.