-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: Allow queueing of Snap dialogs #39599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +4 -0)
|
GuillaumeRx
approved these changes
Jan 28, 2026
OGPoyraz
approved these changes
Jan 28, 2026
Contributor
Builds ready [2bcbbe9]
UI Startup Metrics (1403 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-13.17.0
Issue or pull request that will be included in release 13.17.0
size-XS
team-core-platform
Core Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow queueing of
snap_dialog(the non-legacy type) by adding it to theApprovalControllerconfiguration.This allows Snaps to queue multiple dialogs in the same way that EVM flows do. This also impacts Solana, Bitcoin and Tron.
Changelog
CHANGELOG entry: Added support for queueing non-EVM confirmations
Related issues
https://consensyssoftware.atlassian.net/browse/WPC-36
Manual testing steps
Note
Allows
snap_dialog(non-legacy) confirmations to be queued like other flows.DIALOG_APPROVAL_TYPES.defaulttotypesExcludedFromRateLimitinginapproval-controller-init.tsDIALOG_APPROVAL_TYPESto support the new exclusionWritten by Cursor Bugbot for commit 2bcbbe9. This will update automatically on new commits. Configure here.