perf(accounts-controller): add batch events#8151
Merged
Conversation
d909c62 to
032c44c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add new batched events in the
AccountsControllerto allow consumers to use multiple accounts at once when multiple accounts get updated at once in awithKeyringcall (which will follow-up with aKeyringController:stateChangeevent).References
N/A
Checklist
Note
Low Risk
Additive event emission change: existing per-account events remain, and new batch events are only published when there are additions/removals, making impact to consumers opt-in and low risk.
Overview
Adds new batch messenger events
AccountsController:accountsAddedandAccountsController:accountsRemoved(and exported event types) that emit arrays of accounts/IDs duringKeyringController:stateChangesynchronization.Updates sync logic to publish these batch events after the existing per-account
:accountAdded/:accountRemovedevents (only when non-empty), and extends the test suite and changelog to cover payloads and ordering guarantees.Written by Cursor Bugbot for commit 032c44c. This will update automatically on new commits. Configure here.