Validate terms is Hex, rather than validating each erc20 token address individually#8127
Merged
jeffsmale90 merged 3 commits intomainfrom Mar 8, 2026
Merged
Conversation
packages/gator-permissions-controller/src/decodePermission/rules/erc20TokenPeriodic.ts
Outdated
Show resolved
Hide resolved
packages/gator-permissions-controller/src/decodePermission/rules/erc20TokenPeriodic.ts
Show resolved
Hide resolved
…validate that the terms are Hex
67bf364 to
2383c3a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/gator-permissions-controller/src/decodePermission/rules/makePermissionRule.ts
Show resolved
Hide resolved
- add test coverage of the above
mj-kiwi
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Previously we used the
isHexAddressfunction to validate the erc20 token address. This function expects the input value to be in lowercase hex.Because we are splitting the address from the
terms, now we just validate that the entire terms is valid Hex (using case-insensitive function) in themakePermissionRulefunction.no-changelogbecause this is a fix to an unreleased change.References
Checklist
Note
Medium Risk
Changes shared permission decoding/validation by rejecting any non-hex
termsupfront and removing per-ruletokenAddresshex checks; this can affect which permissions are accepted/rejected across all rules.Overview
Moves hex validation to
makePermissionRuleby rejecting any caveat whosetermsare not a strict hex string (while still allowing empty0x), preventing downstream decoders from operating on malformed data.Removes
isHexAddresschecks from the ERC20 stream/periodic decoders so mixed-case token addresses intermsare accepted, and updates tests to cover mixed-case addresses while dropping rule-specific “invalid token address characters” cases.Written by Cursor Bugbot for commit 8e8f420. This will update automatically on new commits. Configure here.