Conversation
Change-Id: I8c145930e11d934492e7c49e731c1a2ab624473e
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where label processing was creating empty labels due to leading commas in the output. The fix involves stripping leading and trailing commas and removing consecutive commas from the label string.
- Adds comma stripping logic to prevent empty labels in the shell script
- Updates test cases to reflect the expected behavior without leading commas
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| run.sh | Adds logic to strip leading/trailing commas and remove consecutive commas from LABELS_TO_ADD |
| tests/test_labels.py | Updates test expectations to remove leading commas from expected label strings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.