Skip to content

fix: strip comas to avoid creating empty label#12

Merged
sileht merged 1 commit intomainfrom
devs/sileht/labels-fix/I8c145930e11d934492e7c49e731c1a2ab624473e
Sep 25, 2025
Merged

fix: strip comas to avoid creating empty label#12
sileht merged 1 commit intomainfrom
devs/sileht/labels-fix/I8c145930e11d934492e7c49e731c1a2ab624473e

Conversation

@sileht
Copy link
Copy Markdown
Member

@sileht sileht commented Sep 25, 2025

No description provided.

Change-Id: I8c145930e11d934492e7c49e731c1a2ab624473e
Copilot AI review requested due to automatic review settings September 25, 2025 18:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where label processing was creating empty labels due to leading commas in the output. The fix involves stripping leading and trailing commas and removing consecutive commas from the label string.

  • Adds comma stripping logic to prevent empty labels in the shell script
  • Updates test cases to reflect the expected behavior without leading commas

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
run.sh Adds logic to strip leading/trailing commas and remove consecutive commas from LABELS_TO_ADD
tests/test_labels.py Updates test expectations to remove leading commas from expected label strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sileht sileht merged commit afe0553 into main Sep 25, 2025
3 checks passed
@sileht sileht deleted the devs/sileht/labels-fix/I8c145930e11d934492e7c49e731c1a2ab624473e branch September 25, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants