Skip to content

test: testing jinx PR tester CI#2398

Open
maze88 wants to merge 4 commits intoMellanox:masterfrom
maze88:foo
Open

test: testing jinx PR tester CI#2398
maze88 wants to merge 4 commits intoMellanox:masterfrom
maze88:foo

Conversation

@maze88
Copy link
Copy Markdown
Collaborator

@maze88 maze88 commented Apr 11, 2026

not to merge - mock/demo/test only!

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 11, 2026

Greptile Summary

This is a test/demo PR (explicitly marked "not to merge") that extends the CI workflow to support running on GitHub-hosted runners (ubuntu-latest) for pull-request/* branches managed by the NVIDIA copy-pr-bot, in addition to the existing self-hosted runner path. The main workflow changes split the former publish flag into publish_bundle and publish_chart, with Helm charts now also published on PR branches for testing purposes.

Confidence Score: 5/5

PR is explicitly not intended to merge; only a minor NGC CLI version downgrade warrants attention.

All findings are P2. The CI logic changes (conditional runners, skipped steps, split publish flags) are internally consistent and correctly guarded. The only notable anomaly is the NGC CLI version downgrade, which is a style/quality concern rather than a defect.

.github/workflows/ci.yaml — review the NGC CLI version downgrade (3.160.1 → 3.160.0) before any real merge.

Important Files Changed

Filename Overview
.github/workflows/ci.yaml Adds conditional runner selection and step skipping for pull-request/* branches, splits publish into publish_bundle/publish_chart (chart also published on PR branches), and includes a minor NGC CLI version downgrade (3.160.1 → 3.160.0).
.github/copy-pr-bot.yaml Adds a documentation comment pointing to the copy-pr-bot configuration reference — trivial, no issues.
README.md Inserts a test artifact line (foobar (testing PR CI!)...) into the public README — not intended to merge per the PR description.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push Event] --> B{Branch type?}
    B -->|pull-request/N| C[runs-on: ubuntu-latest]
    B -->|master / v*.x / tag| D[runs-on: linux-amd64-cpu4]

    C --> E[docker-build-push\nskip setup-go-proxy\nskip buildkitd-config]
    D --> F[docker-build-push\nsetup-go-proxy\nbuildkitd-config]

    E --> G{publish_bundle?}
    F --> G
    E --> H{publish_chart?}
    F --> H

    G -->|master or tag| I[ocp-bundle job]
    H -->|master, tag, OR pull-request/*| J[helm-package-publish\nNGC CLI 3.160.0\npublish to nvstaging]
Loading

Reviews (5): Last reviewed commit: "Merge branch 'build-image-and-chart-on-p..." | Re-trigger Greptile

Comment thread README.md Outdated
maze88 added 3 commits April 27, 2026 14:01
Signed-off-by: Michael Zeevi <mzeevi@nvidia.com>
Signed-off-by: Michael Zeevi <mzeevi@nvidia.com>
Signed-off-by: Michael Zeevi <mzeevi@nvidia.com>
Signed-off-by: Michael Zeevi <mzeevi@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant