Open
Conversation
Fixes for bounds checking and other weird edge cases that caused it to fail detection. 185 files remain, no crashes.
Member
|
Thank you for this PR.
Does it mean that I should wait before reviewing deeply this PR? |
Contributor
Author
I managed to get it down to 185 actual errors after fixing my test harness to use MediaInfoLib rather than It turned out that these are all bad data:
I think an 0.06% failure rate is to be expected in the wild, so good to go for review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for 4 (of 5) different Amiga
.infoformats, as documented here:http://www.evillabs.net/index.php/Amiga_Icon_Formats
The 5th type are concatenated PNG files with icon metadata inside the first image, they aren't included as part of this patch.
The code was tested first with basic icons here:
https://github.com/steffest/Amiga-Icon-converter/tree/master/test-icons
Then against 300k files extracted from Aminet's archives. MediaInfoLib is pretty robust, bad files detect in the latest version even if they're truncated. The command line doesn't like some of the file names though, which is a separate bug. The full suite of test data is available here:
https://github.com/bitplane/amiga-info-test-files
This was done as part of writing this Python conversion library; I wanted mediainfo to help me identify files for coverage purposes, and wrote this patch to help me.