Add try-catch block to catch module loading errors.#134
Merged
marchermans merged 1 commit intoMcModLauncher:mainfrom May 30, 2025
Merged
Add try-catch block to catch module loading errors.#134marchermans merged 1 commit intoMcModLauncher:mainfrom
marchermans merged 1 commit intoMcModLauncher:mainfrom
Conversation
marchermans
approved these changes
May 30, 2025
shartte
reviewed
May 30, 2025
shartte
requested changes
May 30, 2025
Contributor
shartte
left a comment
shartte
left a comment
There was a problem hiding this comment.
Minor nitpick, then we can merge
shartte
approved these changes
May 30, 2025
This ensures we can log them so they make it to the log file rather than being lost to the void of stdout.
shartte
force-pushed
the
try-catch_moduleerrors
branch
from
e5e1e34 to
f82613d
Compare
Matyrobbrt
added a commit
to neoforged/NeoForge
that referenced
this pull request
Jun 12, 2025
Matyrobbrt
added a commit
to neoforged/NeoForge
that referenced
this pull request
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we can log them so they make it to the log file rather than being lost to the void of stdout.
Band-aid fixes #133
Tested in production with CurseForge by sneakily replacing the jar after it passes the hash check. Normally it cuts off after the mod list (as CF reads the latest.log file rather than capturing the stdout/stderr).
It would be great if this can be [back]ported to as many MC versions as possible.