Remove global BigInt serialiser replacement#131
Open
Slyke wants to merge 1 commit intoMarkoudstaal:mainfrom
Open
Remove global BigInt serialiser replacement#131Slyke wants to merge 1 commit intoMarkoudstaal:mainfrom
Slyke wants to merge 1 commit intoMarkoudstaal:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #130
I couldn't find what this code was doing. I understand that BigInts, for channel IDs and such loose some digits when serialising them with
JSON.stringify(), but in all cases I tested with, all these large numbers were already strings.The reason to remove this include is due to it replacing the global serialiser, which is breaking other things which expect BigInts to not be strings.