Rule/undefined argument value#1153
Merged
bhirsz merged 3 commits intoMarketSquare:masterfrom Dec 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 97.02% 96.20% -0.82%
==========================================
Files 37 39 +2
Lines 4670 5060 +390
==========================================
+ Hits 4531 4868 +337
- Misses 139 192 +53 ☔ View full report in Codecov by Sentry. |
bhirsz
force-pushed
the
rule/undefined-argument-value
branch
from
8eecc4f to
68013e8
Compare
bhirsz
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1149
I thought I'd quickly do the same thing I did for
undefined-argument-default. There was some hidden complexity caused by this version usingarg_nameinstead of${arg_name}.