fix(embedding): prevent unhandled Exception in vllm teardown when torch is missing(#1156)#1257
Open
Abhinav2656 wants to merge 1 commit into
Open
fix(embedding): prevent unhandled Exception in vllm teardown when torch is missing(#1156)#1257Abhinav2656 wants to merge 1 commit into
Abhinav2656 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: Closes #1156
What this PR does:
While looking into the
autorag run webissue reported in #1156 (which happens because the command was deprecated in favor ofrun_web), I noticed it exposed a secondary bug: the app crashes with an unhandled exception on exit if you don't have PyTorch installed.In
autorag/embedding/vllm.py, theatexitteardown hook was hard-importingtorch. For users running the API version of AutoRAG without local GPU dependencies, this causes aModuleNotFoundErrorduring the shutdown routine.I’ve wrapped the teardown imports in a
try/except ImportErrorblock. Now, iftorchisn't found, the app realizes there's no CUDA memory to clean and just exits gracefully.