Make the warning message during mariadb-backup SST more useful #4553
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SST log archive directory cannot be created or is not writable, the path is set to an empty string and a warning is logged. Unfortunately, the warning is logged only after the path has been changed, so, the following message is displayed: > WSREP_SST: [WARNING] The '' directory is not writtable This commit swaps the order of logging and clearing the path so that the failing path is logged. The new output is: > WSREP_SST: [WARNING] The '/tmp/something_invalid' directory is not writable
|
|
github-actions
bot
added
the
External Contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SST log archive directory cannot be created or is not writable, the path is set to an empty string and a warning is logged. Unfortunately, the warning is logged only after the path has been changed, so, the following message is displayed:
This PR swaps the order of logging and clearing the path so that the failing path is logged. The new output is: