Conversation
|
Thank you for raising your pull request and contributing to voscript. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage ? 77.59%
=======================================
Files ? 75
Lines ? 2906
Branches ? 0
=======================================
Hits ? 2255
Misses ? 651
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
Adds elapsed-time logging around the pipeline’s lazy model loading paths to make it easier to spot slow startup/model initialization without changing model selection or device behavior.
Changes:
- Log
perf_counter()-based load durations for faster-whisper, pyannote diarization, and WeSpeaker embedding lazy-loads. - Log load duration for WhisperX alignment model load and DeepFilterNet init.
- Add/adjust unit tests to assert the new timing log lines via
caplog.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
app/pipeline/orchestrator.py |
Adds timing logs for faster-whisper / pyannote / WeSpeaker lazy-loads. |
app/providers/diarization/default.py |
Adds timing log for WhisperX alignment model load (with context fields). |
app/providers/enhance/default.py |
Adds timing log for DeepFilterNet lazy-load/init. |
tests/unit/test_pipeline_model_lifecycle.py |
New assertions verifying orchestrator timing logs. |
tests/unit/test_provider_registry.py |
Captures diarization logger output and asserts WhisperX alignment timing log. |
tests/unit/test_audio_layers.py |
Adds DeepFilterNet timing log test using a stub df module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
❤️ Great PR @MapleEve ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! |
Summary
Validation
Note: one local DeepFilterNet test could not be collected on this machine because the host Python environment has incompatible NumPy/FastAPI artifacts; CI should run in a clean environment.