Skip to content

[Feature] Allow job configuration overrides on instance level#311

Open
heapoutofspace wants to merge 1 commit intoManiMatter:devfrom
heapoutofspace:instance-job-config
Open

[Feature] Allow job configuration overrides on instance level#311
heapoutofspace wants to merge 1 commit intoManiMatter:devfrom
heapoutofspace:instance-job-config

Conversation

@heapoutofspace
Copy link
Copy Markdown

Adds support for instance-level job configuration overrides, allowing different Sonarr/Radarr instances to have different job settings.

The change has been implemented with the following goals in mind:

  • Avoid adding unnecessary complexity or new concepts to the config file.
  • Hide the implementation from the jobs themselves, by handling the override mechanism in the settings module.

Example

job_defaults:
  max_strikes: 3

jobs:
  remove_slow:
    min_speed: 100
  search_unmet_cutoff:
    min_days_between_searches: 7
    max_concurrent_searches: 1

instances:
  sonarr:
    - base_url: "http://sonarr-hd:8989"
      api_key: "key1"
      # Uses global settings

    - base_url: "http://sonarr-4k:8989"
      api_key: "key2"
      jobs:
        remove_slow:
          min_speed: 500  # Override for this instance
        search_unmet_cutoff: false  # Disable for this instance

AI Assistance

While the code itself has been written by hand, some of the documentation and unit tests were generated by Claude Code and then manually verified.

@ManiMatter
Copy link
Copy Markdown
Owner

hi, I am truly sorry I haven't looked into your PR in such a long time. I do appreciate very much that you took the time to contribute.

Unfortunately, I don't have the time to look into it still.
To overcome me being the bottleneck, I am looking to open this repo up to other people who help maintain it, and contributors can review each others code / merge.

Would you be willing to act as a formal contributor? If yes, I will add you, and if I find others (from open PRs), hopefully you can review each others PR and they can be merged.

Thanks for letting me know, and apologies again for my radio silence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants