feat(extract/microsoft): derive Supersedes field from SupersededBy#771
Merged
feat(extract/microsoft): derive Supersedes field from SupersededBy#771
Conversation
MaineK00n
force-pushed
the
MaineK00n/supersedes
branch
10 times, most recently
from
389a89d to
10bccb6
Compare
MaineK00n
changed the title
MaineK00n
force-pushed
the
MaineK00n/supersedes
branch
from
10bccb6 to
37850c0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a derived Supersedes relationship for Microsoft KB data by inverting existing SupersededBy references, so consumers can traverse supersession in both directions at the KB level and per-update level.
Changes:
- Added
Supersedesfields to Microsoft KB and Update models plus a newsupersedestype with comparison helpers. - Implemented
microsoft/util.DeriveSupersedesand refactored extractors to populateSupersedes(including a second pass for msuc/wsusscn2). - Added unit tests and updated golden fixtures to reflect the new
supersedesJSON output.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/extract/types/microsoftkb/update/update.go | Adds Supersedes to Update model and includes it in sorting/comparison. |
| pkg/extract/types/microsoftkb/supersedes/supersedes.go | New type representing “older update this update supersedes”. |
| pkg/extract/types/microsoftkb/supersededby/supersededby.go | Removes no-op Sort() (Compare-only type). |
| pkg/extract/types/microsoftkb/microsoftkb.go | Adds KB-level Supersedes, sorts/compares/merges it. |
| pkg/extract/microsoft/util/util.go | Adds DeriveSupersedes utility that inverts SupersededBy. |
| pkg/extract/microsoft/util/util_test.go | Adds TestDeriveSupersedes covering KB/update inversion + edge cases. |
| pkg/extract/microsoft/wsusscn2/wsusscn2.go | Adds phase-2 pass to read all KBs, derive Supersedes, rewrite KBs. |
| pkg/extract/microsoft/msuc/msuc.go | Adds phase-2 pass to read all KBs, derive Supersedes, rewrite KBs. |
| pkg/extract/microsoft/cvrf/cvrf.go | Derives Supersedes on the in-memory KB set before returning/writing. |
| pkg/extract/microsoft/bulletin/bulletin.go | Derives Supersedes on the in-memory KB set before returning/writing. |
| pkg/extract/microsoft/wsusscn2/testdata/golden/microsoftkb/5066xxx/5066835.json | Updates golden output to include supersedes for an update. |
| pkg/extract/microsoft/msuc/testdata/golden/microsoftkb/5026xxx/5026446.json | Updates golden output to include supersedes. |
| pkg/extract/microsoft/msuc/testdata/golden/microsoftkb/5026xxx/5026372.json | Updates golden output to include supersedes. |
| pkg/extract/microsoft/msuc/testdata/golden/microsoftkb/5025xxx/5025305.json | Updates golden output to include supersedes. |
| pkg/extract/microsoft/cvrf/testdata/golden/microsoftkb/5027xxx/5027543.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/cvrf/testdata/golden/microsoftkb/5027xxx/5027536.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/cvrf/testdata/golden/microsoftkb/5020xxx/5020687.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/cvrf/testdata/golden/microsoftkb/5019xxx/5019964.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/cvrf/testdata/golden/microsoftkb/3147xxx/3147461.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/cvrf/testdata/golden/microsoftkb/3135xxx/3135456.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/bulletin/testdata/golden/microsoftkb/955xxx/955069.json | Updates golden output to include KB-level supersedes. |
| pkg/extract/microsoft/bulletin/testdata/golden/microsoftkb/4014xxx/4014329.json | Updates golden output to include KB-level supersedes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MaineK00n
force-pushed
the
MaineK00n/supersedes
branch
from
37850c0 to
b377d1b
Compare
MaineK00n
force-pushed
the
MaineK00n/supersedes
branch
from
b377d1b to
ca67fd9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MaineK00n
force-pushed
the
MaineK00n/supersedes
branch
from
ca67fd9 to
354e900
Compare
- Add DeriveSupersedes to pkg/extract/microsoft/util, inverting SupersededBy to populate Supersedes at both KB-level and Update-level - Add Supersedes field to KB and Update types - Refactor bulletin, cvrf, msuc, wsusscn2 extractors to use DeriveSupersedes - msuc/wsusscn2 use a two-pass approach: write SupersededBy in pass 1, read all KB files and derive Supersedes in pass 2 - Add TestDeriveSupersedes covering KB-level, Update-level, edge cases Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MaineK00n
force-pushed
the
MaineK00n/supersedes
branch
from
354e900 to
ad5f125
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MaineK00n
added a commit
that referenced
this pull request
Apr 23, 2026
) - Add DeriveSupersedes to pkg/extract/microsoft/util, inverting SupersededBy to populate Supersedes at both KB-level and Update-level - Add Supersedes field to KB and Update types - Refactor bulletin, cvrf, msuc, wsusscn2 extractors to use DeriveSupersedes - msuc/wsusscn2 use a two-pass approach: write SupersededBy in pass 1, read all KB files and derive Supersedes in pass 2 - Add TestDeriveSupersedes covering KB-level, Update-level, edge cases Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MaineK00n
added a commit
that referenced
this pull request
Apr 23, 2026
) - Add DeriveSupersedes to pkg/extract/microsoft/util, inverting SupersededBy to populate Supersedes at both KB-level and Update-level - Add Supersedes field to KB and Update types - Refactor bulletin, cvrf, msuc, wsusscn2 extractors to use DeriveSupersedes - msuc/wsusscn2 use a two-pass approach: write SupersededBy in pass 1, read all KB files and derive Supersedes in pass 2 - Add TestDeriveSupersedes covering KB-level, Update-level, edge cases Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to populate Supersedes at both KB-level and Update-level
read all KB files and derive Supersedes in pass 2