fix: fallback to standard mail ports when no exposure method configured#549
Open
ggueret wants to merge 1 commit intoMailu:masterfrom
Open
fix: fallback to standard mail ports when no exposure method configured#549ggueret wants to merge 1 commit intoMailu:masterfrom
ggueret wants to merge 1 commit intoMailu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using an external ingress controller (e.g., Traefik with TCP routing), all built-in exposure methods are disabled (
ingress.enabled,front.hostPort.enabled,front.externalService.enabledall set tofalse).This results in an empty
PORTSenvironment variable in themailu-envvarsConfigMap, which can cause issues in the admin UI (see Mailu/Mailu#3944).This PR adds a fallback to standard mail ports (
25,465,587,143,993) when no ports are detected through the existing logic.Changes
mailu.enabledPortshelper when no exposure method is configuredTesting
Before:
PORTS: ""After:
PORTS: "25,465,587,143,993"Fixes #548