Skip to content

add values option loadBalancerSourceRanges#404

Open
Sacerdoss wants to merge 2 commits intoMailu:masterfrom
Sacerdoss:add-loadbalancersourceranges
Open

add values option loadBalancerSourceRanges#404
Sacerdoss wants to merge 2 commits intoMailu:masterfrom
Sacerdoss:add-loadbalancersourceranges

Conversation

@Sacerdoss
Copy link
Copy Markdown

@Sacerdoss Sacerdoss commented Apr 28, 2025

Add values option for front.externalService.loadBalancerSourceRanges

Closes #403

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale Issues or pull requests that have not been updated for a while label Sep 28, 2025
@github-actions github-actions bot removed the Stale Issues or pull requests that have not been updated for a while label Oct 18, 2025
@promasu
Copy link
Copy Markdown
Contributor

promasu commented Nov 5, 2025

@Sacerdoss can you rebase please?

@github-actions github-actions bot added area/charts Changes made in the charts directory area/docs Changes made in the docs files labels Nov 6, 2025
@Sacerdoss
Copy link
Copy Markdown
Author

@Sacerdoss can you rebase please?

I have just rebased

Copy link
Copy Markdown
Collaborator

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the rebase apparently. Also there is a small issue, feel free to mention me directly once rebased and fixed.

loadBalancerIP: {{ .loadBalancerIP }}
{{- end }}
{{- if .loadBalancerSourceRanges }}
loadBalancerSourceRanges: {{ toYaml .loadBalancerSourceRanges | nindent 4 }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing an {{- end }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/charts Changes made in the charts directory area/docs Changes made in the docs files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add service.loadBalancerSourceRanges

4 participants